This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Some clarification on the 'matches' terminology.#8120
Closed
Izhaki wants to merge 1 commit into
Closed
Conversation
Added example with reference to Mozilla's Element.matches. Also added another example of Element directive.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Contributor
Author
|
Ahm... This Seems Travis has failed due to reasons that has nothing to do with the commit itself: I don't have write access to this repository. So shall I just push 'dummy' commit to rebuild? |
02dc2aa to
fd2d6c0
Compare
cad9560 to
f294244
Compare
e8dc429 to
e83fab9
Compare
4dd5a20 to
998c61c
Compare
Contributor
|
Landed on master. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request Type: docs
How to reproduce:
Component(s): $compile
Impact: medium
Complexity: small
This issue is related to:
Detailed Description:
Other Comments:
Added example with reference to Mozilla's Element.matches.
Also added another example of Element directive.