This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(jshint): enforce jshint for tests#8026
Closed
shahata wants to merge 1 commit into
Closed
Conversation
|
Wow, that was quick! |
Contributor
Author
|
This loads very slowly in Github since there are a lot of differences. Use this URL in order to ignore whitespace differences: https://github.com/angular/angular.js/pull/8026/files?w=1 (it will load much fatser) |
Contributor
|
LGTM |
Contributor
Author
|
@rodyhaddad can we merge this before it becomes bitrotten? I would really prefer not to have to fix conflicts in this commit :) |
Contributor
|
I was hoping for a "LGTM" from someone else, in case both of us missed anything. I went over it again and it seems all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8023