Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

example of directly calling $filter('orderBy')#7602

Closed
zainengineer wants to merge 1 commit into
angular:masterfrom
zainengineer:patch-1
Closed

example of directly calling $filter('orderBy')#7602
zainengineer wants to merge 1 commit into
angular:masterfrom
zainengineer:patch-1

Conversation

@zainengineer
Copy link
Copy Markdown
Contributor

Request Type: docs

How to reproduce:

Component(s): misc core

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

current example provides | sortBy being used inside HTML. Added example of how to use it directly in JavaScript / Controllers

Other Comments:

@mary-poppins
Copy link
Copy Markdown

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7602)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@zainengineer
Copy link
Copy Markdown
Contributor Author

This is the example working in plunker

http://plnkr.co/edit/hqCqon

@zainengineer
Copy link
Copy Markdown
Contributor Author

issue added using the template

@mary-poppins
Copy link
Copy Markdown

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@caitp
Copy link
Copy Markdown
Contributor

caitp commented May 31, 2014

Changed ever so slightly, but it looks good

@zainengineer
Copy link
Copy Markdown
Contributor Author

Thanks.

Just curious how can I tell whether someone has signed CLA electronically or not? is there some lookup available?

When I signed it, It displayed a message that they will get back shortly and I have still not heard back from google.

@caitp
Copy link
Copy Markdown
Contributor

caitp commented Jun 1, 2014

It's visible to internal people. Our pet robot Mary Poppins will also post that your CLA signature has been verified at some point, although I'm not sure how frequently that script runs (weekly? daily? I'm not sure). A CLA signature isn't necessary for documentation enhancements like this, but if you're pushing a feature, we'll know it's been signed before pushing it in

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants