Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix for ng-app called ng=app in diagram image. Issue #6473#7528

Closed
codenameEli wants to merge 1 commit into
angular:masterfrom
codenameEli:doc-image-fix
Closed

Fix for ng-app called ng=app in diagram image. Issue #6473#7528
codenameEli wants to merge 1 commit into
angular:masterfrom
codenameEli:doc-image-fix

Conversation

@codenameEli
Copy link
Copy Markdown

REF LINK: #6473

@mary-poppins
Copy link
Copy Markdown

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7528)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@caitp
Copy link
Copy Markdown
Contributor

caitp commented May 21, 2014

I think this is the first docs PR i've seen that touched binary files, hah. I think this will probably be merged tomorrow.

@caitp caitp added type: docs and removed gh: PR labels May 21, 2014
@caitp caitp added this to the 1.3.0 milestone May 21, 2014
@codenameEli
Copy link
Copy Markdown
Author

Awesome glad to hear.

petebacondarwin pushed a commit that referenced this pull request May 21, 2014
The ng-app was called ng=app in diagram image.

Closes #6473
Closes #7528
RichardLitt pushed a commit to RichardLitt/angular.js that referenced this pull request May 24, 2014
The ng-app was called ng=app in diagram image.

Closes angular#6473
Closes angular#7528
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants