Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

dedupe jshint options#7118

Closed
CodisRedding wants to merge 1 commit into
angular:masterfrom
CodisRedding:dedupe-jshint
Closed

dedupe jshint options#7118
CodisRedding wants to merge 1 commit into
angular:masterfrom
CodisRedding:dedupe-jshint

Conversation

@CodisRedding
Copy link
Copy Markdown

@CodisRedding CodisRedding commented Apr 15, 2014

The .jshintrc file in src/ had a duplicate nodeName_ option. I removed the dupe.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Apr 15, 2014

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7118)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

caitp added a commit that referenced this pull request Apr 15, 2014
@caitp
fix(limitTo): do not convert Infinity to NaN
fcdac65 
parseInt(Infinity, 10) will result in NaN, which becomes undesirable when the expected behaviour is
to return the entire input.

I believe this is possibly useful as a way to toggle input limiting based on certain factors.

Closes #6771
Closes #7118
@caitp caitp closed this in 5dee9e4 Apr 15, 2014
@caitp
Copy link
Copy Markdown
Contributor

caitp commented Apr 15, 2014

oh god I don't know why I used that issue number

@caitp caitp reopened this Apr 15, 2014
@caitp
Copy link
Copy Markdown
Contributor

caitp commented Apr 15, 2014

My bad :( Too many tabs open

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Apr 18, 2014

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@CodisRedding
Copy link
Copy Markdown
Author

CodisRedding commented Apr 19, 2014

signed and sent

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Apr 21, 2014

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@btford
Copy link
Copy Markdown
Contributor

btford commented Jun 10, 2014

Thanks! Landed as 73e3e85.

@btford btford closed this Jun 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes type: chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CodisRedding @mary-poppins @caitp @btford