Update version-info.js#6912
Conversation
replaced grep with match Windows operating systems do not have grep by default
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
Thanks! |
|
I had some more build issues with version 1.2.15 mostly related to the docs task, these issues were not present in the latest version. There were also issues with the java startup parameters for closure, but I couldn't determine if it was related to my setup or if it's a general windows issue. In /lib/grunt/utils.js: ~ I had to include the current path in the classpath list like so; (line 212) Again, I didn't generate pull requests for these issues since I wasn't 100% sure what the best solution here is, or what the impact would be. |
|
Ok, thanks for the notes! |
Replaced grep with match Windows operating systems do not have grep by default Closes #6912.
replaced grep with match
Windows operating systems do not have grep by default