From 974db27d57e8d0fcb37cfcf0886b7fd6c327cf9c Mon Sep 17 00:00:00 2001 From: Parashuram Date: Wed, 19 Feb 2014 09:10:16 -0800 Subject: [PATCH 1/2] fix(doc-gen): Run Gulp on Windows too Using node_module/.bin/gulp will enable to gulp command to run both on Windows and Linux. In its current form, opening a Javascript file on Windows will not run the doc generation. --- lib/grunt/plugins.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/grunt/plugins.js b/lib/grunt/plugins.js index 87c4719b0d65..5f1cdf399155 100644 --- a/lib/grunt/plugins.js +++ b/lib/grunt/plugins.js @@ -35,7 +35,7 @@ module.exports = function(grunt) { grunt.registerTask('docs', 'create angular docs', function(){ - var gruntProc = shelljs.exec('node_modules/gulp/bin/gulp.js --gulpfile docs/gulpfile.js'); + var gruntProc = shelljs.exec('node_modules/.bin/gulp --gulpfile docs/gulpfile.js'); if (gruntProc.code !== 0) { throw new Error('doc generation failed'); } From 89793b80fbcfbe8ebad90d7e4ab1dadcd441197f Mon Sep 17 00:00:00 2001 From: sgrebnov Date: Wed, 26 Feb 2014 12:10:30 +0400 Subject: [PATCH 2/2] fix(doc-gen): Enclosed Gulp call in quotes Requires to correctly resolve path on Windows --- lib/grunt/plugins.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/grunt/plugins.js b/lib/grunt/plugins.js index 5f1cdf399155..58455d48d988 100644 --- a/lib/grunt/plugins.js +++ b/lib/grunt/plugins.js @@ -35,7 +35,7 @@ module.exports = function(grunt) { grunt.registerTask('docs', 'create angular docs', function(){ - var gruntProc = shelljs.exec('node_modules/.bin/gulp --gulpfile docs/gulpfile.js'); + var gruntProc = shelljs.exec('"node_modules/.bin/gulp" --gulpfile docs/gulpfile.js'); if (gruntProc.code !== 0) { throw new Error('doc generation failed'); }