This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/di): Use square bracket notation for $inject annotation#5104
Closed
ewinslow wants to merge 1 commit into
Closed
docs(guide/di): Use square bracket notation for $inject annotation#5104ewinslow wants to merge 1 commit into
ewinslow wants to merge 1 commit into
Conversation
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Contributor
|
@ewinslow - thanks for the PR. By the way, the commit message subject should not start with a capital letter. |
Contributor
|
At this line we are also using a property lookup rather than a square bracket dereference to actually get the property. I guess you are not applying this aggressive obfuscation to the angular.js code? |
petebacondarwin
added a commit
that referenced
this pull request
Nov 27, 2013
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This recommendation is better as it ensures that the
$injectproperty doesn't get minified when aggressively obfuscating code.Re: CLA -- I work at Google.