This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/scope): correct CSS rules in Scope Hierarchies example#4838
Closed
aevange wants to merge 1 commit into
Closed
docs(guide/scope): correct CSS rules in Scope Hierarchies example#4838aevange wants to merge 1 commit into
aevange wants to merge 1 commit into
Conversation
Remove extra selectors .show-scope .doc-example-live. These classes do not appear using the provided code; the example will not work. Fiddle example of change: http://jsfiddle.net/72KP4/
Contributor
|
These CSS classes do appear on the actual documentation pages - just not if you click "Edit". Without them the entire page becomes bordered with red: I think the better solution is to put in a specific class within the example and use that to scope the CSS styling |
Contributor
Author
|
Since these are the CSS rules for the actual pages I agree with your solution. |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
The CSS styling in the ng-scope demo was using CSS classes (`.doc-example-live` and `.show-scope') to prevent the styling for the demo from affecting the entire page. Unfortunately elements containing these classes did not appear in JSFiddle or Plunker when you click edit. This fix moves the `.show-scope' class inside the demo (renaming it `.show-scope-demo`) and removes the reliance on `.doc-example-live` altogether. Closes angular#4838
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
The CSS styling in the ng-scope demo was using CSS classes (`.doc-example-live` and `.show-scope') to prevent the styling for the demo from affecting the entire page. Unfortunately elements containing these classes did not appear in JSFiddle or Plunker when you click edit. This fix moves the `.show-scope' class inside the demo (renaming it `.show-scope-demo`) and removes the reliance on `.doc-example-live` altogether. Closes angular#4838
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove extra selectors .show-scope and .doc-example-live.
These classes do not appear using the provided code; the example will not work.
Fiddle example of change: http://jsfiddle.net/72KP4/