chore(dependencies): revert to marked@0.2.9 to fix CI builds#4822
Conversation
|
Hmm, well, mostly fixes CI builds... something is borked elsewhere I suppose, too :( |
|
I don't know if it solves all of the issues, but I'd be interested in seeing a saucelabs build to see how close it gets. |
|
So, it looks like in order to migrate to 0.2.10, everything gets all async-crazy, and it doesn't seem very fun to migrate everything over. I'm not totally sure it's worth doing. Maybe some things could be wrapped in promises to keep it less crazy. I'm not sure what is causing the travis failure for this quick fix though, for some reason my ie8 vm is not letting me reproduce the issue, so if someone has access to a legitimate windows PC to try and sort that out, that would be cool. |
|
I guess the 95102a5 test still needs to be fixed, and I really don't understand what IE8 is complaining about since that file hasn't been touched in forever... |
|
Yes, Brian is going to take a look today/tomorrow at that test. On 9 November 2013 23:25, Caitlin Potter notifications@github.com wrote:
|
|
@caitp - the travis build is failing for IE8 because of this change 5614fd2#diff-ce57d523476c1be91e154668e90187e9R196 |
The marked npm library brought in a breaking change at 0.2.10. This commit ensures that we get exactly the version we want. Closes angular#4822
The marked npm library brought in a breaking change at 0.2.10. This commit ensures that we get exactly the version we want. Closes angular#4822
marked v0.2.10 breaking test:docgen
Tests on travis have been failing the past few days, so I wanted to dig around for the cause.
To reproduce:
I think the simplest way to fix travis build would be to remove the
~operator before the version number in package.json, but a more robust fix would involve migrating the code. Clearly there are some breaking changes introduced in v0.2.10