This repository was archived by the owner on Apr 12, 2024. It is now read-only.
prevent confusion about args of input function (e2e testing)#4655
Closed
netpoetica wants to merge 1 commit into
Closed
prevent confusion about args of input function (e2e testing)#4655netpoetica wants to merge 1 commit into
netpoetica wants to merge 1 commit into
Conversation
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Add note to user that input fn is using ng-model instead of HTML name attribute ~5 users on forums were snagged by this assumption http://docs.angularjs.org/guide/dev_guide.e2e-testing#comment-898079915
Contributor
Author
|
Keith Rosenberg |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Add note that `input()` fn matches ng-model instead of HTML name attribute. About five users on forums were snagged by this assumption: http://docs.angularjs.org/guide/dev_guide.e2e-testing#comment-898079915 Closes angular#4655
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Add note that `input()` fn matches ng-model instead of HTML name attribute. About five users on forums were snagged by this assumption: http://docs.angularjs.org/guide/dev_guide.e2e-testing#comment-898079915 Closes angular#4655
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating docs to prevent confusion about args of input() function being an ng-model vs HTML "name" attribute: http://docs.angularjs.org/guide/dev_guide.e2e-testing#comment-941247365, http://docs.angularjs.org/guide/dev_guide.e2e-testing#comment-734673956, http://docs.angularjs.org/guide/dev_guide.e2e-testing#comment-898079915