This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(select): fix migrate warning for jQuery.fn.attr('selected')#4122
Closed
colincasey wants to merge 1 commit into
Closed
chore(select): fix migrate warning for jQuery.fn.attr('selected')#4122colincasey wants to merge 1 commit into
colincasey wants to merge 1 commit into
Conversation
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Contributor
|
So this LGTM |
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Jun 14, 2014
jQuery suggests using `prop` rather than `attr` to modify the `select` property of an element. You can see the full list of migration warnings for jQuery: https://github.com/jquery/jquery-migrate/blob/master/warnings.md Closes angular#4107 Closes angular#4122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full listing of jQuery migrate warning can be found here - https://github.com/jquery/jquery-migrate/blob/master/warnings.md
Closes #4107