This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngDefer): new ngDefer directive to defer compilation until condition is met#16552
Closed
wyrfel wants to merge 1 commit into
Closed
feat(ngDefer): new ngDefer directive to defer compilation until condition is met#16552wyrfel wants to merge 1 commit into
wyrfel wants to merge 1 commit into
Conversation
…tion is met ngNonBindable can halt Angular compilation altogether at a certain point in the tree. This is a useful optimisation feature. But even more useful is to delay compilation until a certain condition is met so that parts of the tree can be compiled only when needed. E.g. content of pre-loaded popups or complex navigation dropdowns can be compiled only when they become visible. This new ngDefer directive halts comilation similar to ngNonBindable, but registers a watcher on the condition provided to the ngDefer attribute and will continue compilation once the condition returns a trueish value.
Contributor
|
Hi, interesting PR - but I don't see how this is different from |
Member
|
Note that since #12078 transluded content is lazily compiled only if/when needed. |
Author
|
You're right, after stripping most of our custom stuff for submission here the directives functionality as submitted here is very close to There are however, a few differences:
All of these make for better performance, in particular not modifying the DOM means there is no re-layout event triggered in the browser, which is crucial for fast initial page rendering (in progressive enhancement use-cases). But looking at it again, it might make more sense to implement this as an extension to |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
ngNonBindable can halt Angular compilation altogether at a certain point in the
tree. This is a useful optimisation feature.
But even more useful is to delay compilation until a certain condition is met
so that parts of the tree can be compiled only when needed. E.g. content of
pre-loaded popups or complex navigation dropdowns can be compiled only when
they become visible.
There is currently no builtin way to do just that.
What is the new behavior (if this is a feature change)?
This new ngDefer directive halts compilation similar to ngNonBindable, but
registers a watcher on the condition provided to the ngDefer attribute and
will continue compilation once the condition returns a trueish value.
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements