Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Issue 14279#14369

Merged
petebacondarwin merged 0 commit into
angular:masterfrom
petebacondarwin:issue-14279
Apr 4, 2016
Merged

Issue 14279#14369
petebacondarwin merged 0 commit into
angular:masterfrom
petebacondarwin:issue-14279

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin commented Apr 4, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bug
What is the current behavior? (You can also link to an open issue here)

Fixes #14279

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

@petebacondarwin petebacondarwin added this to the 1.5.4 milestone Apr 4, 2016
@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Apr 4, 2016

LGTM

(A comment briefly explaining what the two temporary copies (on factory and controller) are necessary for (e.g. what version of the router etc) would be helpful.)

@petebacondarwin petebacondarwin merged commit 4b2bc60 into angular:master Apr 4, 2016
petebacondarwin added a commit that referenced this pull request Apr 4, 2016
@petebacondarwin
feat($compile): put custom annotations on DDO
f338e96 
Closes #14369
Closes #14279
Closes #14284
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@gkalpak gkalpak

Labels

cla: yes

Projects

None yet

Milestone

1.5.4

Development

Successfully merging this pull request may close these issues.

bug($compile): custom annotations don't work on named controllers

3 participants

@petebacondarwin @gkalpak @googlebot