Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs: docs(guide/Animations): Fixed a typo in Animations doc app.cofig#14111

Closed
marvin-SL wants to merge 1 commit into
angular:masterfrom
marvin-SL:patch-1
Closed

docs: docs(guide/Animations): Fixed a typo in Animations doc app.cofig#14111
marvin-SL wants to merge 1 commit into
angular:masterfrom
marvin-SL:patch-1

Conversation

@marvin-SL
Copy link
Copy Markdown
Contributor

@marvin-SL marvin-SL commented Feb 23, 2016

line 312 fixed a typo : app.config instead of app.cofig

@marvin-SL
docs(guide/Animations): describe your change...
dd34f0a 
line 312 fixed a typo : `app.cofig` instead of `app.config`
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 23, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 23, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@marvin-SL
Copy link
Copy Markdown
Contributor Author

marvin-SL commented Feb 23, 2016

I signed it!

@googlebot
Copy link
Copy Markdown

googlebot commented Feb 23, 2016

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 23, 2016

CLAs look good, thanks!

@gkalpak gkalpak self-assigned this Feb 23, 2016
@gkalpak gkalpak closed this in 2ffda41 Feb 23, 2016
gkalpak pushed a commit that referenced this pull request Feb 23, 2016
@marvin-SL @gkalpak
docs(guide/animations): fix typos in example
33b3901 
Closes #14111
@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Feb 23, 2016

Backported to v1.5.x as 33b3901.

@marvin-SL marvin-SL deleted the patch-1 branch February 23, 2016 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@gkalpak gkalpak

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marvin-SL @googlebot @gkalpak