Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(jscs): active disallowMultipleLineBreaks rule#11794

Closed
sebholstein wants to merge 1 commit into
angular:masterfrom
sebholstein:jscs-line-breaks
Closed

chore(jscs): active disallowMultipleLineBreaks rule#11794
sebholstein wants to merge 1 commit into
angular:masterfrom
sebholstein:jscs-line-breaks

Conversation

@sebholstein
Copy link
Copy Markdown
Contributor

No description provided.

@caitp
Copy link
Copy Markdown
Contributor

caitp commented May 3, 2015

not a fan of this, the vertical whitespace between blocks makes a lot of sense, and is used in other goog projects like closure-library and v8 --- plus it's unnecessary churn

@sebholstein
Copy link
Copy Markdown
Contributor Author

@caitp I'm not a fan of this too. But as this rule is listed in .jscs.json.todo I thought "it's an open TODO - I'll try to fix it".

@caitp
Copy link
Copy Markdown
Contributor

caitp commented May 3, 2015

It makes perfect sense for linebreaks that aren't between function definitions/their surrounding comments --- but I'd prefer we enforce that there are two blank lines between function definitions. Still, since that will cause a lot of churn, it's probably not worth it

@petebacondarwin
Copy link
Copy Markdown
Contributor

I think we meant to remove that TODO list now. I think we agreed not to implement any more of those rules.

@petebacondarwin petebacondarwin added this to the Ice Box milestone May 5, 2015
@hzoo
Copy link
Copy Markdown
Contributor

hzoo commented May 5, 2015

Yeah I think I forgot to remove the file a while ago - was from #10772 (comment). Can do a PR to remove / update jscs?

@sebholstein
Copy link
Copy Markdown
Contributor Author

Ok guys, I close this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants