This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($injector): add strictDi property to $injector instance#11734
Closed
kentcdodds wants to merge 1 commit into
Closed
feat($injector): add strictDi property to $injector instance#11734kentcdodds wants to merge 1 commit into
kentcdodds wants to merge 1 commit into
Conversation
Add a strictDi property which is true or false when creating an instance of an injector. Closes angular#11728
Author
|
Just doing some clean-up. This will obviously never get merged (because it's not really needed). Thanks! |
Contributor
|
@kentcdodds if you look at #12446 then that posted a very reasonable reason to merge this. Anyhow, I would like to consider this for 1.5. Can you put the PR back? |
Author
|
Oh, cool. Didn't notice that. Sure thing :-) I've made several PRs to angular. But if this one gets merged, it'll be the first time I've contributed code to angular that actually runs in people's code 😄 |
Contributor
|
In a few days we should branch for 1.5, will merge this just after that |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a strictDi property which is true or false when creating an instance of an injector.
Closes #11728