This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngMessageFormat): ensure bindings are valid for Protractor#11644
Closed
petebacondarwin wants to merge 1 commit into
Closed
fix(ngMessageFormat): ensure bindings are valid for Protractor#11644petebacondarwin wants to merge 1 commit into
petebacondarwin wants to merge 1 commit into
Conversation
Contributor
Author
|
To recreate the issue we just need to have an ICU plural message interpolation, the run a protractor spec that tries to find an element by a binding.... {{ app.filteredRestaurants.length, plural,
=0 {No restaurants found!}
=1 {Only one restaurant found!}
other {# restaurants found.}
}} var userNameDisplay = element(by.binding('app.user.name'));The call to But without this fix we have a binding that consists of an array with on |
Contributor
|
Thanks. I'll work on this PR in the next hour or so! |
Contributor
|
I'm waiting for Travis status. However, I think this one is good to merge once it's confirmed to pass on Travis. See #11649 which has the changes to the test files and some symbol renaming protection. (Please merge that one if I go to bed before I'm able to merge this.) |
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, yes, I know. This PR requires unit tests, etc, etc.
Just pushing here for @chirayuk to take care of. Thanks @chirayuk !