Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngTransclude): example markup consistency#10298

Closed
hartz89 wants to merge 1 commit into
angular:masterfrom
hartz89:patch-1
Closed

docs(ngTransclude): example markup consistency#10298
hartz89 wants to merge 1 commit into
angular:masterfrom
hartz89:patch-1

Conversation

@hartz89
Copy link
Copy Markdown
Contributor

@hartz89 hartz89 commented Dec 2, 2014

The second of the <br> tags used in the example HTML is self-closed but the first is not.

The first of the <br> tags used in the example HTML is self-closed but the first is not.
@googlebot
Copy link
Copy Markdown

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@hartz89
Copy link
Copy Markdown
Contributor Author

hartz89 commented Dec 2, 2014

I've signed a CLA now.

Thanks,

Ryan P. Hartzfeld
Software Engineer
www.rhartzfeld.com http://rhartzfeld.com

On Tue, Dec 2, 2014 at 3:54 PM, googlebot notifications@github.com wrote:

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source
project, in which case you'll need to sign a Contributor License Agreement
(CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub
username or you're using a different email address. Check the information
on your CLA https://cla.developers.google.com/clas or see this help
article on setting the email on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Once you've done that, please reply here to let us know. If you signed the
CLA as a corporation, please let us know the company's name.


Reply to this email directly or view it on GitHub
#10298 (comment).

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 2, 2014
@pkozlowski-opensource
Copy link
Copy Markdown
Member

  • grep -r '<br/>' src/ | wc -l => 86
  • grep -r '<br>' src/ | wc -l => 58

Merging :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants