Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngAnimate + $$RAFProvider : crashes when browser doesn't support requestAnimationFrame or is prefixed with 'moz' #6535

Closed
Closed
ngAnimate + $$RAFProvider : crashes when browser doesn't support requestAnimationFrame or is prefixed with 'moz'#6535
Labels
browser: Firefoxcomponent: ngAnimatefrequency: highseverity: regressiontype: bug
Milestone
1.3.x - superluminal-nudge
@atomrc

Description

@atomrc
atomrc
opened on Mar 4, 2014

The RAFProvider is adding a supported property to indicate whether the browser supports or not the requestAnimationFrame (see

angular.js/src/ng/raf.js

Line 18 in 04d7317

raf.supported = !!requestAnimationFrame;
) but the ngAnimate doesn't check this property before using it (see https://github.com/angular/angular.js/blob/master/src/ngAnimate/animate.js#L261).

I would be happy to make a pull request on this but my question is :
is it best to add a fallback on a timeout directly in the RAFProvider or to check for the supportedproperty every time it is used ?

I think just adding the mozRequestAnimationFrame would be a good start.

Metadata

Metadata

Assignees

No one assigned

    Labels

    browser: Firefoxcomponent: ngAnimatefrequency: highseverity: regressiontype: bug

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions