feat($interval): pass arguments in callback

PatrickJS · PatrickJS · commit fe6d7f75d3a6 · 2015-01-03T22:00:05.000-08:00
`setInterval ` allows you to pass arguments into the callback function in the …3rd argument. Since that’s taken I added it to the …5th http://mdn.io/setInterval#Syntax
diff --git a/src/ng/interval.js b/src/ng/interval.js
@@ -132,7 +132,8 @@ function $IntervalProvider() {
       * </example>
       */
     function interval(fn, delay, count, invokeApply) {
-      var setInterval = $window.setInterval,
+      var args = arguments.length > 4 ? sliceArgs(arguments, 4) : [],
+          setInterval = $window.setInterval,
           clearInterval = $window.clearInterval,
           iteration = 0,
           skipApply = (isDefined(invokeApply) && !invokeApply),
@@ -141,7 +142,9 @@ function $IntervalProvider() {
 
       count = isDefined(count) ? count : 0;
 
-      promise.then(null, null, fn);
+      promise.then(null, null, function() {
+        fn.apply(null, args);
+      });
 
       promise.$$intervalId = setInterval(function tick() {
         deferred.notify(iteration++);
diff --git a/test/ng/intervalSpec.js b/test/ng/intervalSpec.js
@@ -142,6 +142,23 @@ describe('$interval', function() {
   }));
 
 
+  it('should allow you to specify a number of arguments', inject(function($interval, $window) {
+    var task1 = jasmine.createSpy('task1'),
+        task2 = jasmine.createSpy('task2'),
+        task3 = jasmine.createSpy('task3');
+    $interval(task1, 1000, 1, true, 'Task1');
+    $interval(task2, 1000, 1, true, 'Task2');
+    $interval(task3, 1000, 1, true, 'I', 'am', 'a', 'Task3', 'spy');
+
+    $window.flush(1000);
+    expect(task1).toHaveBeenCalledWith('Task1');
+    $window.flush(1000);
+    expect(task2).toHaveBeenCalledWith('Task2');
+    $window.flush(1000);
+    expect(task3).toHaveBeenCalledWith('I', 'am', 'a', 'Task3', 'spy');
+  }));
+
+
   it('should return a promise which will be updated with the count on each iteration',
       inject(function($interval, $window) {
     var log = [],
