fix($browser): should use first value for a cookie.

chirayuk · chirayuk · commit 3952d35abe33 · 2013-05-11T09:28:14.000-07:00
With this change, $browser.cookies()["foo"] will behave like docCookies.getItem("foo") where docCookies is defined at https://developer.mozilla.org/en-US/docs/DOM/document.cookie This fixes the issue where, if there's a value for the XSRF-TOKEN cookie value with the path /, then that value is used for all applications in the domain even if they set path specific values for XSRF-TOKEN. Closes #2635
diff --git a/src/ng/browser.js b/src/ng/browser.js
@@ -297,7 +297,13 @@ function Browser(window, document, $log, $sniffer) {
           cookie = cookieArray[i];
           index = cookie.indexOf('=');
           if (index > 0) { //ignore nameless cookies
-            lastCookies[unescape(cookie.substring(0, index))] = unescape(cookie.substring(index + 1));
+            var name = unescape(cookie.substring(0, index));
+            // the first value that is seen for a cookie is the most
+            // specific one.  values for the same cookie name that
+            // follow are for less specific paths.
+            if (lastCookies[name] === undefined) {
+              lastCookies[name] = unescape(cookie.substring(index + 1));
+            }
           }
         }
       }
diff --git a/test/ng/browserSpecs.js b/test/ng/browserSpecs.js
@@ -304,6 +304,13 @@ describe('browser', function() {
         expect(browser.cookies().foo).toEqual('bar=baz');
       });
 
+      it('should return the the first value provided for a cookie', function() {
+        // For a cookie that has different values that differ by path, the
+        // value for the most specific path appears first.  browser.cookies()
+        // should provide that value for the cookie.
+        document.cookie = 'foo="first"; foo="second"';
+        expect(browser.cookies()['foo']).toBe('"first"');
+      });
 
       it ('should unescape cookie values that were escaped by puts', function() {
         document.cookie = "cookie2%3Dbar%3Bbaz=val%3Due;path=/";

Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,13 @@ function Browser(window, document, $log, $sniffer) {`
`297`	`297`	`cookie = cookieArray[i];`
`298`	`298`	`index = cookie.indexOf('=');`
`299`	`299`	`if (index > 0) { //ignore nameless cookies`
`300`		`- lastCookies[unescape(cookie.substring(0, index))] = unescape(cookie.substring(index + 1));`
	`300`	`+ var name = unescape(cookie.substring(0, index));`
	`301`	`+ // the first value that is seen for a cookie is the most`
	`302`	`+ // specific one. values for the same cookie name that`
	`303`	`+ // follow are for less specific paths.`
	`304`	`+ if (lastCookies[name] === undefined) {`
	`305`	`+ lastCookies[name] = unescape(cookie.substring(index + 1));`
	`306`	`+ }`
`301`	`307`	`}`
`302`	`308`	`}`
`303`	`309`	`}`