refactor(@angular/cli): implement experimental unified run_target facade and strategy dispatcher#33215
Open
clydin wants to merge 1 commit into
Open
refactor(@angular/cli): implement experimental unified run_target facade and strategy dispatcher#33215clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new run_target tool to the Angular CLI MCP server, enabling the execution of project targets such as build, test, and lint through a unified interface. The implementation includes a generic execution strategy and supporting unit tests. Feedback focuses on improving the robustness of option serialization—specifically handling array values and avoiding the stringification of null or undefined values—as well as refining the Zod schema to restrict option types to primitives and correcting minor punctuation in user-facing descriptions.
aa51411 to
3b5a67e
Compare
3b5a67e to
180d9b4
Compare
…ade and strategy dispatcher Introduce the unified `run_target` MCP tool and the underlying builder strategy dispatcher in a dedicated `tools/run-target` subdirectory. This architecture leverages the strategy pattern to delegate Angular CLI target executions (build, test, lint, e2e) to specialized internal strategies, defaulting to a universal `GenericTargetStrategy` fallback.
180d9b4 to
857cecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the unified
run_targetMCP tool and the underlying builder strategy dispatcher in a dedicatedtools/run-targetsubdirectory. This architecture leverages the strategy pattern to delegate Angular CLI target executions (build, test, lint, e2e) to specialized internal strategies, defaulting to a universalGenericTargetStrategyfallback.