ng lint, is linting node_modules files. #5063

Activity

1. delasteve commented on Feb 27, 2017

   

   delasteve

   on Feb 27, 2017

   Last edited by delasteve

   Contributor

   More actions

   Hey @daBishMan, this is because the library you're using publishes .ts files as well as .js files. TSLint would do the same if you did tslint --project=src/tsconfig.app.json. Check out the CHANGELOG.md for how to ignore node_modules. This should be happening in beta.32.3. I'd be surprised if it wasn't.

   https://github.com/angular/angular-cli/blob/master/CHANGELOG.md#breaking-changes-3

   Discussed in #4350, fixed in #4437
2. daBishMan commented on Feb 27, 2017

   

   daBishMan

   on Feb 27, 2017

   Author

   More actions

   Thank you so much for your quick reply.

   I have included the following in .angular.cli.json based on my understanding. I looked at https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/lib/config/schema.json

   "lint": [ { "project": "src/tsconfig.app.json", "exclude": [ "../node_modules/**/*" ] }, { "project": "src/tsconfig.spec.json" }, { "project": "e2e/tsconfig.e2e.json" } ],

   this is how I excluded in .angular-cli.json, but it is still happening, am I missing something.
3. delasteve commented on Feb 27, 2017

   

   delasteve

   on Feb 27, 2017

   Contributor

   More actions

   I misspoke when I suggested it was in the CHANGELOG.md, sorry. I was thinking of the first PR I did that changed how linting was done, not the update that had allowed exclude.

   #4350 (comment) discusses what needs to be done.

   In short, this should fix your issue.

   "lint": [
     {
       "project": "src/tsconfig.app.json",
       "exclude": "**/node_modules/**/*"
     },
     {
       "project": "src/tsconfig.spec.json",
       "exclude": "**/node_modules/**/*"
     },
     {
       "project": "e2e/tsconfig.e2e.json",
       "exclude": "**/node_modules/**/*"
     }
   ],
   

   👍React with 👍17Reacted by Martin Nuc, Oleksiy Kachynskyy, Nive Venugopal, Łukasz Kliś, Jan Jachacz, kol-li, Serhii Sol, Denis Loginov, Marc Pérez, Mopar and 7 more

   ❤️React with ❤️2Reacted by Kevin Upton and zensign
4. daBishMan commented on Feb 27, 2017

   

   daBishMan

   on Feb 27, 2017

   Author

   More actions

   thank you so much again for your help. This does fix my issue.

   I am going to close this issue.

   👍React with 👍1Reacted by delasteve
5. daBishMan

   closed this as completedon Feb 27, 2017
6. lexigren commented on Mar 2, 2017

   

   lexigren

   on Mar 2, 2017

   More actions

   My config:

   "lint": [
       {
         "files": "src/**/*.ts",
         "project": "src/tsconfig.json",
         "exclude": "**/node_modules/**/*"
       },
       {
         "files": "e2e/**/*.ts",
         "project": "e2e/tsconfig.json",
         "exclude": "**/node_modules/**/*"
       }
     ]
   

   Still linting node_modules.
   My version is 1.0.0-beta.28.3.

   👍React with 👍6Reacted by David Morcillo, Daniela Meneses, Jean-Philippe Pellerin, Sylvain Dumont, floby and Ernest Lombardi
7. dinvlad

   added a commit that references this issue on Oct 20, 2017

   Properly exclude /api/ folder from linting

   ...

   4567575
8. angular-automatic-lock-bot commented on Sep 6, 2019

   

   angular-automatic-lock-botBot

   on Sep 6, 2019

   More actions

   This issue has been automatically locked due to inactivity.
   Please file a new issue if you are encountering a similar or related problem.

   Read more about our automatic conversation locking policy.

   _{This action has been performed automatically by a bot.}
9. angular-automatic-lock-bot

   locked and limited conversation to collaborators on Sep 6, 2019