Skip to content

Commit fdbd49a

Browse files
alan-agius4clydin
alan-agius4
authored and
clydin
committed
refactor: move public api golden files under golden directory
1 parent eb81121 commit fdbd49a

File tree

18 files changed

+10
-14
lines changed

18 files changed

+10
-14
lines changed

‎.prettierignore‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/bazel-out/
22
/docs/design/analytics.md
33
/dist-schema/
4-
/etc/api/
4+
/goldens/public-api
55
/packages/angular_devkit/build_angular/test/
66
/packages/angular_devkit/core/src/workspace/json/test/
77
/tests/

‎CONTRIBUTING.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -288,18 +288,18 @@ To test if your change effect the public API you need to run the API guardian on
288288
For example in case `@angular-devkit/core` package was modified you need to run:
289289

290290
```bash
291-
yarn bazel test //etc/api:angular_devkit_core_api
291+
yarn bazel test //goldens/public-api:angular_devkit_core_api
292292
```
293293

294294
You can also test all packages by running:
295295
```bash
296-
yarn bazel test //etc/api ...
296+
yarn bazel test //goldens/public-api ...
297297
```
298298

299299
If you modified the public API, the test will fail. To update the golden files you need to run:
300300

301301
```bash
302-
yarn bazel run //etc/api:angular_devkit_core_api.accept
302+
yarn bazel run //goldens/public-api:angular_devkit_core_api.accept
303303
```
304304

305305
**Note**: In some cases we use aliased symbols to create namespaces.

‎etc/README.md‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

etc/api/BUILD.bazel renamed to goldens/public-api/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ load("@npm//ts-api-guardian:index.bzl", "ts_api_guardian_test")
2929
bundle[1],
3030
),
3131
],
32-
golden = "angular_cli/etc/api/%s/%s/%s.d.ts" % (
32+
golden = "angular_cli/goldens/public-api/%s/%s/%s.d.ts" % (
3333
bundle[0],
3434
bundle[1],
3535
bundle[2],

etc/api/angular_devkit/architect/src/index.d.ts renamed to goldens/public-api/angular_devkit/architect/src/index.d.ts

File renamed without changes.

etc/api/angular_devkit/architect/testing/index.d.ts renamed to goldens/public-api/angular_devkit/architect/testing/index.d.ts

File renamed without changes.

etc/api/angular_devkit/benchmark/src/index.d.ts renamed to goldens/public-api/angular_devkit/benchmark/src/index.d.ts

File renamed without changes.

etc/api/angular_devkit/build_optimizer/src/_golden-api.d.ts renamed to goldens/public-api/angular_devkit/build_optimizer/src/_golden-api.d.ts

File renamed without changes.

etc/api/angular_devkit/core/node/_golden-api.d.ts renamed to goldens/public-api/angular_devkit/core/node/_golden-api.d.ts

File renamed without changes.

etc/api/angular_devkit/core/node/testing/index.d.ts renamed to goldens/public-api/angular_devkit/core/node/testing/index.d.ts

File renamed without changes.

0 commit comments

Comments
 (0)