refactor(@angular-devkit/core): remove deprecated fs, object and array APIs

alan-agius4 · dgp1130 · commit a0c02af7e340 · 2022-01-31T11:35:18.000-08:00
BREAKING CHANGE:

The below APIs have been removed without replacement. Users should leverage other Node.js or other APIs.
- `fs` namespace
- `clean`
- `mapObject`
diff --git a/goldens/public-api/angular_devkit/core/node/index.md b/goldens/public-api/angular_devkit/core/node/index.md
@@ -229,14 +229,6 @@ type FileBufferLike = ArrayBufferLike;
 // @public (undocumented)
 function fileBufferToString(fileBuffer: FileBuffer): string;
 
-declare namespace fs {
-    export {
-        isFile,
-        isDirectory
-    }
-}
-export { fs }
-
 // @public (undocumented)
 function getTypesOfSchema(schema: JsonSchema): Set<string>;
 
@@ -293,12 +285,6 @@ class IndentLogger extends Logger {
     constructor(name: string, parent?: Logger | null, indentation?: string);
 }
 
-// @public @deprecated (undocumented)
-function isDirectory(filePath: string): boolean;
-
-// @public @deprecated (undocumented)
-function isFile(filePath: string): boolean;
-
 // @public (undocumented)
 function isJobHandler<A extends JsonValue, I extends JsonValue, O extends JsonValue>(value: unknown): value is JobHandler<A, I, O>;
 
diff --git a/goldens/public-api/angular_devkit/core/src/index.md b/goldens/public-api/angular_devkit/core/src/index.md
@@ -189,9 +189,6 @@ export class CircularDependencyFoundException extends BaseException {
 // @public
 function classify(str: string): string;
 
-// @public @deprecated (undocumented)
-export function clean<T>(array: Array<T | undefined>): Array<T>;
-
 // @public (undocumented)
 export class ContentHasMutatedException extends BaseException {
     constructor(path: string);
@@ -353,7 +350,7 @@ function dasherize(str: string): string;
 // @public
 function decamelize(str: string): string;
 
-// @public (undocumented)
+// @public
 export function deepCopy<T>(value: T): T;
 
 // @public (undocumented)
@@ -1037,13 +1034,6 @@ class LoggingAnalytics implements Analytics {
 // @public (undocumented)
 type LogLevel = 'debug' | 'info' | 'warn' | 'error' | 'fatal';
 
-// @public @deprecated (undocumented)
-export function mapObject<T, V>(obj: {
-    [k: string]: T;
-}, mapper: (k: string, v: T) => V): {
-    [k: string]: V;
-};
-
 // @public (undocumented)
 export class MergeConflictException extends BaseException {
     constructor(path: string);
diff --git a/packages/angular_devkit/core/node/fs.ts b/packages/angular_devkit/core/node/fs.ts
diff --git a/packages/angular_devkit/core/node/index.ts b/packages/angular_devkit/core/node/index.ts
@@ -7,9 +7,8 @@
  */
 
 import * as experimental from './experimental/jobs/job-registry';
-import * as fs from './fs';
 
 export * from './cli-logger';
 export * from './host';
 
-export { experimental, fs };
+export { experimental };
diff --git a/packages/angular_devkit/core/src/utils/array.ts b/packages/angular_devkit/core/src/utils/array.ts
diff --git a/packages/angular_devkit/core/src/utils/index.ts b/packages/angular_devkit/core/src/utils/index.ts
@@ -9,7 +9,6 @@
 import * as tags from './literals';
 import * as strings from './strings';
 
-export * from './array';
 export * from './object';
 export * from './template';
 export * from './partially-ordered-set';
diff --git a/packages/angular_devkit/core/src/utils/object.ts b/packages/angular_devkit/core/src/utils/object.ts
@@ -6,18 +6,6 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-/** @deprecated Since v12.0, unused by the Angular tooling */
-export function mapObject<T, V>(
-  obj: { [k: string]: T },
-  mapper: (k: string, v: T) => V,
-): { [k: string]: V } {
-  return Object.keys(obj).reduce((acc: { [k: string]: V }, k: string) => {
-    acc[k] = mapper(k, obj[k]);
-
-    return acc;
-  }, {});
-}
-
 const copySymbol = Symbol();
 
 export function deepCopy<T>(value: T): T {
