fix(@angular-devkit/build-angular): remove support for Node.js v16

clydin · alan-agius4 · commit 5bf7022c4749 · 2023-08-14T10:57:54.000+02:00
BREAKING CHANGE: Node.js v16 support has been removed Node.js v16 is planned to be End-of-Life on 2023-09-11. Angular will stop supporting Node.js v16 in Angular v17. For Node.js release schedule details, please see: https://github.com/nodejs/release#release-schedule
diff --git a/.circleci/dynamic_config.yml b/.circleci/dynamic_config.yml
@@ -25,11 +25,11 @@ parameters:
 # See https://circleci.com/docs/2.0/caching/#restoring-cache for how prefixes work in CircleCI.
 var_1: &cache_key v1-angular_devkit-16.14-{{ checksum "yarn.lock" }}
 var_1_win: &cache_key_win v1-angular_devkit-win-16.14-{{ checksum "yarn.lock" }}
-var_3: &default_nodeversion '16.14'
-var_3_major: &default_nodeversion_major '16'
+var_3: &default_nodeversion '18.13'
+var_3_major: &default_nodeversion_major '18'
 # The major version of node toolchains. See tools/toolchain_info.bzl
 # NOTE: entries in this array may be repeated elsewhere in the file, find them before adding more
-var_3_all_major: &all_nodeversion_major ['16', '18']
+var_3_all_major: &all_nodeversion_major ['18']
 # Workspace initially persisted by the `setup` job, and then enhanced by `setup-and-build-win`.
 # https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs
 # https://circleci.com/blog/deep-diving-into-circleci-workspaces/
@@ -141,8 +141,8 @@ commands:
   setup_windows:
     steps:
       - initialize_env
-      - run: nvm install 16.14.2
-      - run: nvm use 16.14.2
+      - run: nvm install 18.13.0
+      - run: nvm use 18.13.0
       - run: npm install -g yarn@1.22.10 @bazel/bazelisk@${BAZELISK_VERSION}
       - run: node --version
       - run: yarn --version
@@ -299,15 +299,15 @@ jobs:
             PWD: .
           command: |
             mkdir X:/ramdisk/e2e
-            bazel test --define=E2E_TEMP=X:/ramdisk/e2e --define=E2E_SHARD_TOTAL=$env:CIRCLE_NODE_TOTAL --define=E2E_SHARD_INDEX=$env:CIRCLE_NODE_INDEX --config=e2e //tests/legacy-cli:e2e.npm_node16
+            bazel test --define=E2E_TEMP=X:/ramdisk/e2e --define=E2E_SHARD_TOTAL=$env:CIRCLE_NODE_TOTAL --define=E2E_SHARD_INDEX=$env:CIRCLE_NODE_INDEX --config=e2e //tests/legacy-cli:e2e.npm_node18
           # This timeout provides time for the actual tests to timeout and report status
           # instead of CircleCI stopping the job without test failure information.
           no_output_timeout: 40m
       - fail_fast
       - store_artifacts:
-          path: dist/testlogs/tests/legacy-cli/e2e.npm_node16
+          path: dist/testlogs/tests/legacy-cli/e2e.npm_node18
       - store_test_results:
-          path: dist/testlogs/tests/legacy-cli/e2e.npm_node16
+          path: dist/testlogs/tests/legacy-cli/e2e.npm_node18
 
 workflows:
   version: 2
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -79,7 +79,7 @@ jobs:
       defaultVersion: 16
     strategy:
       matrix:
-        version: [16, 18]
+        version: [18]
     steps:
       - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
         with:
@@ -105,7 +105,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node: [16, 18]
+        node: [18]
         subset: [npm, yarn, esbuild]
         shard: [0, 1, 2, 3]
         exclude:
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-18.10.0
+18.13.0
diff --git a/WORKSPACE b/WORKSPACE
@@ -51,11 +51,6 @@ rules_pkg_dependencies()
 # Setup the Node.js toolchain
 load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")
 
-nodejs_register_toolchains(
-    name = "node16",
-    node_version = "16.14.2",
-)
-
 nodejs_register_toolchains(
     name = "node18",
     node_version = "18.13.0",
@@ -64,7 +59,7 @@ nodejs_register_toolchains(
 # Set the default nodejs toolchain to the latest supported major version
 nodejs_register_toolchains(
     name = "nodejs",
-    node_version = "18.10.0",
+    node_version = "18.13.0",
 )
 
 load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")
diff --git a/constants.bzl b/constants.bzl
@@ -1,5 +1,5 @@
 # Engine versions to stamp in a release package.json
-RELEASE_ENGINES_NODE = "^16.14.0 || >=18.10.0"
+RELEASE_ENGINES_NODE = ">=18.13.0"
 RELEASE_ENGINES_NPM = "^6.11.0 || ^7.5.6 || >=8.0.0"
 RELEASE_ENGINES_YARN = ">= 1.13.0"
 
diff --git a/docs/DEVELOPER.md b/docs/DEVELOPER.md
@@ -6,7 +6,7 @@ To get started locally, follow these instructions:
 
 1. If you haven't done it already, [make a fork of this repo](https://github.com/angular/angular-cli/fork).
 1. Clone to your local computer using `git`.
-1. Make sure that you have Node `v14.20`, `v16.14` or `v18.10` installed. See instructions [here](https://nodejs.org/en/download/).
+1. Make sure that you have Node `v18.13` or higher installed. See instructions [here](https://nodejs.org/en/download/).
 1. Make sure that you have `yarn` installed; see instructions [here](https://yarnpkg.com/lang/en/docs/install/).
 1. Run `yarn` (no arguments) from the root of your clone of this project to install dependencies.
 
@@ -86,8 +86,8 @@ You can find more info about debugging [tests with Bazel in the docs.](https://g
 ### End to end tests
 
 - For a complete list of test targets use the following Bazel query: `yarn bazel query "tests(//tests/...)"`
-- Run a subset of the tests: `yarn bazel test //tests/legacy-cli:e2e_node16 --test_filter="tests/i18n/ivy-localize-*"`
-- Use `bazel run` to debug failing tests debugging: `yarn bazel run //tests/legacy-cli:e2e_node16 --test_arg="--glob=tests/basic/aot.ts"`
+- Run a subset of the tests: `yarn bazel test //tests/legacy-cli:e2e_node18 --test_filter="tests/i18n/ivy-localize-*"`
+- Use `bazel run` to debug failing tests debugging: `yarn bazel run //tests/legacy-cli:e2e_node18 --test_arg="--glob=tests/basic/aot.ts"`
 - Provide additional `e2e_runner` options using `--test_arg`: `--test_arg="--yarn"`
 
 When running the debug commands, Node will stop and wait for a debugger to attach.
diff --git a/package.json b/package.json
@@ -39,7 +39,7 @@
     "url": "https://github.com/angular/angular-cli.git"
   },
   "engines": {
-    "node": "^16.14.0 || ^18.10.0",
+    "node": "^18.13.0",
     "yarn": ">=1.21.1 <2",
     "npm": "Please use yarn instead of NPM to install dependencies"
   },
@@ -101,7 +101,7 @@
     "@types/karma": "^6.3.0",
     "@types/less": "^3.0.3",
     "@types/loader-utils": "^2.0.0",
-    "@types/node": "^16.11.7",
+    "@types/node": "^18.13.0",
     "@types/node-fetch": "^2.1.6",
     "@types/npm-package-arg": "^6.1.0",
     "@types/pacote": "^11.1.3",
diff --git a/packages/angular/cli/bin/ng.js b/packages/angular/cli/bin/ng.js
@@ -55,18 +55,13 @@ if (version[0] % 2 === 1) {
   );
 
   require('./bootstrap');
-} else if (
-  version[0] < 14 ||
-  (version[0] === 14 && version[1] < 20) ||
-  (version[0] === 16 && version[1] < 14) ||
-  (version[0] === 18 && version[1] < 10)
-) {
-  // Error and exit if less than 14.20, 16.14 or 18.10
+} else if (version[0] < 18 || (version[0] === 18 && version[1] < 13)) {
+  // Error and exit if less than 18.13
   console.error(
     'Node.js version ' +
       process.version +
       ' detected.\n' +
-      'The Angular CLI requires a minimum Node.js version of either v14.20, v16.14 or v18.10.\n\n' +
+      'The Angular CLI requires a minimum Node.js version of v18.13.\n\n' +
       'Please update your Node.js version or visit https://nodejs.org/ for additional instructions.\n',
   );
 
diff --git a/packages/angular/cli/lib/cli/index.ts b/packages/angular/cli/lib/cli/index.ts
@@ -16,7 +16,7 @@ import { writeErrorToLogFile } from '../../src/utilities/log-file';
 
 export { VERSION } from '../../src/utilities/version';
 
-const MIN_NODEJS_VERSION = [16, 13] as const;
+const MIN_NODEJS_VERSION = [18, 13] as const;
 
 /* eslint-disable no-console */
 export default async function (options: { cliArgs: string[] }) {
diff --git a/packages/angular_devkit/build_angular/BUILD.bazel b/packages/angular_devkit/build_angular/BUILD.bazel
@@ -299,10 +299,6 @@ ts_library(
 LARGE_SPECS = {
     "application": {
         "shards": 10,
-        "tags": [
-            # TODO: This is broken as app-shell tests do not work in Node versions prior to 18.13 due to Zone.js and SafePromise.
-            "node16-broken",
-        ],
         "extra_deps": [
             "@npm//buffer",
         ],
diff --git a/tools/toolchain_info.bzl b/tools/toolchain_info.bzl
@@ -3,17 +3,11 @@
 # the name can be anything the user wants this is just added to the target to create unique names
 # the order will match against the order in the TOOLCHAIN_VERSION list.
 TOOLCHAINS_NAMES = [
-    "node16",
     "node18",
 ]
 
 # this is the list of toolchains that should be used and are registered with nodejs_register_toolchains in the WORKSPACE file
 TOOLCHAINS_VERSIONS = [
-    select({
-        "@bazel_tools//src/conditions:linux_x86_64": "@node16_linux_amd64//:node_toolchain",
-        "@bazel_tools//src/conditions:darwin": "@node16_darwin_amd64//:node_toolchain",
-        "@bazel_tools//src/conditions:windows": "@node16_windows_amd64//:node_toolchain",
-    }),
     select({
         "@bazel_tools//src/conditions:linux_x86_64": "@node18_linux_amd64//:node_toolchain",
         "@bazel_tools//src/conditions:darwin": "@node18_darwin_amd64//:node_toolchain",
diff --git a/yarn.lock b/yarn.lock
@@ -131,7 +131,6 @@
 
 "@angular/build-tooling@https://github.com/angular/dev-infra-private-build-tooling-builds.git#22a9a75114d5e80907054f01b9fa360972de1c05":
   version "0.0.0-9931e1a8d1b62fcd2267e89f9993a494856cc1cd"
-  uid "22a9a75114d5e80907054f01b9fa360972de1c05"
   resolved "https://github.com/angular/dev-infra-private-build-tooling-builds.git#22a9a75114d5e80907054f01b9fa360972de1c05"
   dependencies:
     "@angular-devkit/build-angular" "16.2.0-next.4"
@@ -292,7 +291,6 @@
 
 "@angular/ng-dev@https://github.com/angular/dev-infra-private-ng-dev-builds.git#2c4d983ef0f1f000a8554b3b7fbf7f1061c877d3":
   version "0.0.0-9931e1a8d1b62fcd2267e89f9993a494856cc1cd"
-  uid "2c4d983ef0f1f000a8554b3b7fbf7f1061c877d3"
   resolved "https://github.com/angular/dev-infra-private-ng-dev-builds.git#2c4d983ef0f1f000a8554b3b7fbf7f1061c877d3"
   dependencies:
     "@yarnpkg/lockfile" "^1.1.0"
@@ -3475,10 +3473,10 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-10.17.60.tgz#35f3d6213daed95da7f0f73e75bcc6980e90597b"
   integrity sha512-F0KIgDJfy2nA3zMLmWGKxcH2ZVEtCZXHHdOQs2gSaQ27+lNeEfGxzkIw90aXswATX7AZ33tahPbzy6KAfUreVw==
 
-"@types/node@^16.11.7":
-  version "16.18.39"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.39.tgz#aa39a1a87a40ef6098ee69689a1acb0c1b034832"
-  integrity sha512-8q9ZexmdYYyc5/cfujaXb4YOucpQxAV4RMG0himLyDUOEr8Mr79VrqsFI+cQ2M2h89YIuy95lbxuYjxT4Hk4kQ==
+"@types/node@^18.13.0":
+  version "18.17.5"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-18.17.5.tgz#c58b12bca8c2a437b38c15270615627e96dd0bc5"
+  integrity sha512-xNbS75FxH6P4UXTPUJp/zNPq6/xsfdJKussCWNOnz4aULWIRwMgP1LgaB5RiBnMX1DPCYenuqGZfnIAx5mbFLA==
 
 "@types/npm-package-arg@*", "@types/npm-package-arg@^6.1.0":
   version "6.1.1"
@@ -10827,7 +10825,6 @@ sass@^1.55.0:
 
 "sauce-connect-proxy@https://saucelabs.com/downloads/sc-4.9.1-linux.tar.gz":
   version "0.0.0"
-  uid "9310bc860f7870a1f872b11c4dc6073a1ad34e5e"
   resolved "https://saucelabs.com/downloads/sc-4.9.1-linux.tar.gz#9310bc860f7870a1f872b11c4dc6073a1ad34e5e"
 
 saucelabs@^1.5.0:
