feat(@angular-devkit/build-angular): remove experimentalImportFactories option

filipesilva · alexeagle · commit 0f9de92dcb88 · 2019-04-22T16:16:58.000-07:00
It will just be always be used when applicable. Fix #14218
diff --git a/packages/angular/cli/lib/config/schema.json b/packages/angular/cli/lib/config/schema.json
@@ -886,11 +886,6 @@
             "webWorkerTsConfig": {
               "type": "string",
               "description": "TypeScript configuration for Web Worker modules."
-            },
-            "experimentalImportFactories": {
-              "description": "**EXPERIMENTAL** Transform import statements for lazy routes to import factories when using View Engine. Should only be used when switching back and forth between View Engine and Ivy. See https://angular.io/guide/ivy for usage information.",
-              "type": "boolean",
-              "default": false
             }
           },
           "additionalProperties": false,
diff --git a/packages/angular_devkit/build_angular/src/angular-cli-files/models/build-options.ts b/packages/angular_devkit/build_angular/src/angular-cli-files/models/build-options.ts
@@ -60,7 +60,6 @@ export interface BuildOptions {
   forkTypeChecker: boolean;
   profile?: boolean;
   es5BrowserSupport?: boolean;
-  experimentalImportFactories?: boolean;
 
   main: string;
   index: string;
diff --git a/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/typescript.ts b/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/typescript.ts
@@ -91,7 +91,6 @@ function _createAotPlugin(
     contextElementDependencyConstructor: require('webpack/lib/dependencies/ContextElementDependency'),
     logger: wco.logger,
     directTemplateLoading: true,
-    importFactories: buildOptions.experimentalImportFactories,
     ...options,
   };
 
diff --git a/packages/angular_devkit/build_angular/src/browser/schema.json b/packages/angular_devkit/build_angular/src/browser/schema.json
@@ -316,11 +316,6 @@
       "default": false,
       "x-deprecated": true
     },
-    "experimentalImportFactories": {
-      "description": "**EXPERIMENTAL** Transform import statements for lazy routes to import factories when using View Engine. Should only be used when switching back and forth between View Engine and Ivy. See https://angular.io/guide/ivy for usage information.",
-      "type": "boolean",
-      "default": false
-    },
     "webWorkerTsConfig": {
       "type": "string",
       "description": "TypeScript configuration for Web Worker modules."
diff --git a/tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts b/tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts
@@ -89,13 +89,6 @@ export default async function () {
   await ng('e2e', '--prod');
 
   // Test `import()` style lazy load.
-  if (!ivyProject) {
-    await updateJsonFile('angular.json', json => {
-      // Add the experimental flag to import factories in View Engine.
-      const buildTarget = json['projects'][projectName]['architect']['build'];
-      buildTarget['options']['experimentalImportFactories'] = true;
-    });
-  }
   // Both Ivy and View Engine should support it.
   await replaceLoadChildren(`() => import('./lazy/lazy.module').then(m => m.LazyModule)`);
 
