fix(testing): allow test component builder to override directives fro…#8217
Closed
juliemr wants to merge 1 commit into
Closed
fix(testing): allow test component builder to override directives fro…#8217juliemr wants to merge 1 commit into
juliemr wants to merge 1 commit into
Conversation
…m lists When a component uses a list of directives, such as `ROUTER_DIRECTIVES`, make `TestComponentBuilder#overrideDirective` work properly for members of the list. Closes angular#7397
Member
Author
|
@vikerman mind taking a look at this one? |
|
Merging PR #8217 on behalf of @hansl to branch presubmit-hansl-pr-8217. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a component uses a list of directives, such as
ROUTER_DIRECTIVES,make
TestComponentBuilder#overrideDirectivework properly for membersof the list.
Closes #7397