Skip to content

fix(MockBackend): move import of ReplaySubject under src/#8091

Closed
micaelmbagira wants to merge 2 commits into
angular:masterfrom
micaelmbagira:fix-rxjs-import
Closed

fix(MockBackend): move import of ReplaySubject under src/#8091
micaelmbagira wants to merge 2 commits into
angular:masterfrom
micaelmbagira:fix-rxjs-import

Conversation

@micaelmbagira
Copy link
Copy Markdown

rxjs moved Subjects under /src since beta.6
This fixes #8036
See ReactiveX/rxjs#1557

@pxwise
Copy link
Copy Markdown

pxwise commented Apr 15, 2016

This is causing our karma tests (rxjs-beta6) to diverge from our live site vendor files (rxjs-beta2). Is this expected to land in the next beta?

@mhevery mhevery self-assigned this Apr 17, 2016
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Apr 17, 2016

If you change package.json then these instructions need to be followed. https://github.com/angular/angular/blob/master/npm-shrinkwrap.readme.md Could you please update the PR per those instructions.

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Apr 17, 2016

Closing in favor of #8047

@mhevery mhevery closed this Apr 17, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XHR error loading jspm_packages/npm/rxjs@5.0.0-beta.6/subject/ReplaySubject.js

4 participants