Skip to content

I18n expansion syntax#7977

Closed
vsavkin wants to merge 5 commits into
angular:masterfrom
vsavkin:i18n_expansion_syntax
Closed

I18n expansion syntax#7977
vsavkin wants to merge 5 commits into
angular:masterfrom
vsavkin:i18n_expansion_syntax

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Apr 8, 2016

Add support for

{messages.length, plural,
  =0 {zero}
  =1 {one}
  =other {more than 1}
}

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Apr 8, 2016

@kara can you have a look as well?

mhevery
mhevery reviewed Apr 8, 2016
View reviewed changes
Comment thread modules/angular2/test/compiler/html_lexer_spec.ts Outdated
Copy link
Copy Markdown
Contributor

@mhevery mhevery Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML embedded in the i18n will need to be parsed.

Copy link
Copy Markdown
Contributor Author

@vsavkin vsavkin Apr 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

@mhevery mhevery added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 8, 2016
@mhevery mhevery assigned vsavkin and unassigned mhevery Apr 8, 2016
@vsavkin vsavkin force-pushed the i18n_expansion_syntax branch from f3cb709 to d294d32 Compare April 12, 2016 18:47
@vsavkin vsavkin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 12, 2016
@vsavkin vsavkin force-pushed the i18n_expansion_syntax branch 2 times, most recently from 74991a8 to 30c2823 Compare April 13, 2016 21:32
@vsavkin vsavkin force-pushed the i18n_expansion_syntax branch from 30c2823 to 7c5b590 Compare April 13, 2016 23:01
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Apr 15, 2016

User @robertmesserle does not have PR merging privileges.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Apr 15, 2016

Merging PR #7977 on behalf of @robertmesserle to branch presubmit-robertmesserle-pr-7977.

@mhevery mhevery closed this in c6244d1 Apr 18, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vsavkin @mhevery @mary-poppins @robertmesserle @googlebot