Skip to content

chore(lint): re-enable linter and fix violations#7800

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:tslint
Closed

chore(lint): re-enable linter and fix violations#7800
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:tslint

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

fixes #7798

@alexeagle
Copy link
Copy Markdown
Contributor Author

cc @IgorMinar

@alexeagle alexeagle force-pushed the tslint branch 2 times, most recently from 809ad8e to 5f5bb26 Compare March 28, 2016 21:51
@IgorMinar IgorMinar added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 29, 2016
@IgorMinar IgorMinar assigned IgorMinar and unassigned tbosch Mar 29, 2016
@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 30, 2016
@mary-poppins
Copy link
Copy Markdown

Merging PR #7800 on behalf of @alxhub to branch presubmit-alxhub-pr-7800.

@alxhub
Copy link
Copy Markdown
Member

alxhub commented Apr 7, 2016

@alexeagle, can you rebase this and fix current lint issues? Then I can merge it in.

@alxhub alxhub assigned alexeagle and unassigned IgorMinar Apr 7, 2016
@alxhub alxhub added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Apr 7, 2016
@alexeagle alexeagle force-pushed the tslint branch 2 times, most recently from 284ad38 to d5f2f0e Compare April 7, 2016 22:22
@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 7, 2016
@alexeagle alexeagle assigned alxhub and unassigned alexeagle Apr 7, 2016
@alexeagle
Copy link
Copy Markdown
Contributor Author

Green other than browserstack nonsense

@mary-poppins
Copy link
Copy Markdown

Merging PR #7800 on behalf of @alxhub to branch presubmit-alxhub-pr-7800.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter not linting

6 participants