Remove es6 promise#7677
Conversation
As of zone.js@0.6* we no longer require an es6-promise polyfill. The polyfill is only needed on browsers that don't have native Promise support.
|
// @wardbell - fyi |
|
To be clear, is the shim still required for older supported browsers e.g. IE10 and IE11? I'm not sure which browsers you're including in "evergreen browsers" |
|
My understanding is that edge is the only evergreen browser from MS. MDN concurs
|
|
@wardbell I share your opinion that majority of apps will have to support IE1, but it will be easy and more fair (and explicit) for them to add es6-shim to app dependencies, without having it as default dependency. And small subset of apps, which don't have to support IE11 (mobile apps, for example), will have benefit of it. "Pay for what you use" :) |
|
CI is green. |
|
It comes down to what is said here:
If we put a warning about it somewhere, that this shim is only needed on those platforms, I think it's reasonable enough to remove it from the angular peer deps. But it would be expected that in any best practices document the shim is listed, for without it apps would not work on one browser and one mobile platform. It's also worth noting that component libraries should care nothing for this shim. Maybe not even for other shims. |
|
New zones will polyfill Promises regardless if they are in the browser, so removing the polyfill here is the right thing, and it will have no impact on any legacy browsers. |
|
Merging PR #7677 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7677. |
|
Merging PR #7677 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7677. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
drop obsolete es6-promise dependency
* What is the current behavior? (You can also link to an open issue here)
* What is the new behavior (if this is a feature change)?
not really. projects that already require es6-promise polyfill will now contain unnecessary dependency which should be removed if only everygreen browsers are targeted by the app.