Skip to content

fix(metadata): Allow spacing in multiple selectors#7418

Merged
mhevery merged 1 commit into
angular:masterfrom
lacolaco:laco-fix-view-query-selector
May 26, 2016
Merged

fix(metadata): Allow spacing in multiple selectors#7418
mhevery merged 1 commit into
angular:masterfrom
lacolaco:laco-fix-view-query-selector

Conversation

@lacolaco
Copy link
Copy Markdown
Contributor

@lacolaco lacolaco commented Mar 4, 2016

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix
  • What is the current behavior? (You can also link to an open issue here)
    ViewQuery allows only comma-separated selector WITHOUT spaces.
@ViewQuery("child1,child2") children; // OK
@ViewQuery("child1, child2") children; // NG

@lacolaco lacolaco force-pushed the laco-fix-view-query-selector branch from f03d915 to fd7480f Compare March 4, 2016 04:28
@lacolaco lacolaco force-pushed the laco-fix-view-query-selector branch from fd7480f to 3e36f34 Compare April 13, 2016 23:37
@lacolaco
Copy link
Copy Markdown
Contributor Author

lacolaco commented Apr 13, 2016

@naomiblack could you assign someone for this?

@lacolaco
Copy link
Copy Markdown
Contributor Author

lacolaco commented Apr 15, 2016

cc/ @tbosch

@lacolaco
Copy link
Copy Markdown
Contributor Author

lacolaco commented May 16, 2016

can someone review this?

cc/ @IgorMinar

@lacolaco lacolaco force-pushed the laco-fix-view-query-selector branch from 3e36f34 to 1dadb93 Compare May 19, 2016 23:45
@lacolaco lacolaco force-pushed the laco-fix-view-query-selector branch from 1dadb93 to e9b3df1 Compare May 19, 2016 23:49
@mhevery mhevery added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels May 20, 2016
@mhevery mhevery self-assigned this May 20, 2016
@mhevery mhevery merged commit b2e804c into angular:master May 26, 2016
@ericmartinezr ericmartinezr mentioned this pull request Sep 21, 2018
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mhevery mhevery

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

comma separated list in ViewQuery factory only returning first match in beta.0 - beta.3

4 participants

@lacolaco @mhevery @naomiblack @googlebot