Skip to content

chore(build): remove workaround now that we are on rxjs-beta.2#7139

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:typings2
Closed

chore(build): remove workaround now that we are on rxjs-beta.2#7139
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:typings2

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

No description provided.

@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 18, 2016
@alexeagle
Copy link
Copy Markdown
Contributor Author

Ping!

@alexeagle
Copy link
Copy Markdown
Contributor Author

@jeffbcross 🌺

@alexeagle
Copy link
Copy Markdown
Contributor Author

This is now breaking me in google3.
@vikerman please LG, since Jeff seems busy.

@robwormald robwormald added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 4, 2016
@robwormald robwormald assigned alexeagle and unassigned jeffbcross Mar 4, 2016
@robwormald
Copy link
Copy Markdown
Contributor

LGTM

@vikerman vikerman added the action: merge The PR is ready for merge by the caretaker label Mar 4, 2016
@vikerman
Copy link
Copy Markdown
Contributor

vikerman commented Mar 4, 2016

TAP Green

@vikerman
Copy link
Copy Markdown
Contributor

vikerman commented Mar 4, 2016

@alexeagle - The Travis build keeps failing for this PR - can you check?

@mary-poppins
Copy link
Copy Markdown

Merging PR #7139 on behalf of @vikerman to branch presubmit-vikerman-pr-7139.

@evmar evmar removed the action: merge The PR is ready for merge by the caretaker label Mar 9, 2016
@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Apr 8, 2016

@alexeagle Can your rebase and get this green.

@jeffbcross
Copy link
Copy Markdown
Contributor

Closing in favor of #7985

@jeffbcross jeffbcross closed this Apr 9, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants