add signal consumer breakpoints#69383
Draft
eduhmc wants to merge 2 commits into
Draft
Conversation
eduhmc
commented
Jun 16, 2026
Contributor
- feat(core): expose debuggableFn for effects in signal debug graph
- feat(devtools): add prototype for setting signal breakpoints
Expose the underlying user function (fn) as debuggableFn for effect nodes in the signal debug graph. This allows debugging tools to locate and set breakpoints on effects.
Add a 'Set Breakpoint' button to the signal details panel. It uses the Chrome Console Utilities debug() and inspect() APIs to programmatically set breakpoints and navigate to the source code without requiring extra permissions for the prototype.
8bac4db to
6a0fd1c
Compare
SkyZeroZx
reviewed
Jun 16, 2026
| override setSignalBreakpoint(position: SignalNodePosition, target: Frame): void { | ||
| const setBreakpoint = ` | ||
| (() => { | ||
| const fn = inspectedApplication.findSignalNodeByPosition('${JSON.stringify(position)}'); |
Contributor
There was a problem hiding this comment.
Could it be that we want to use stringifyAndEscape to follow the same standard that was added at #69309?
Suggested change
| const fn = inspectedApplication.findSignalNodeByPosition('${JSON.stringify(position)}'); | |
| const fn = inspectedApplication.findSignalNodeByPosition('${stringifyAndEscape(position)}'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.