fix(docs-infra): support header values containing apostrophes#69268
Open
MeAkib wants to merge 1 commit into
Open
fix(docs-infra): support header values containing apostrophes#69268MeAkib wants to merge 1 commit into
MeAkib wants to merge 1 commit into
Conversation
Update the `headerRule` regex to capture the complete quoted header value. The previous pattern excluded quote characters from the content and failed to parse headers such as:
```angular-ts {avoid, header: "Can't inject interface"}
```
The new pattern matches everything between the opening and closing quote delimiters.
JeanMeche
reviewed
Jun 9, 2026
| const metadataStr = match[2].trim(); | ||
|
|
||
| const headerRule = /header\s*:\s*(['"`])([^'"`]+)\1/; // The 2nd capture matters here | ||
| const headerRule = /header\s*:\s*(['"`])(.*?)\1/; // The 2nd capture matters here |
Member
There was a problem hiding this comment.
I'm afraid that's not safe enough.
I would only approve this change we a sufficient test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
headerRuleregex to capture the complete quoted header value. The previous pattern excluded quote characters from the content and failed to parse headers such as:The new pattern matches everything between the opening and closing quote delimiters.
What is the current behavior?
Showing Only "Can" not full text.
https://angular.dev/guide/di/debugging-and-troubleshooting-di#trying-to-inject-interfaces
What is the new behavior?
Showing full text "Can't inject interface"