fix(forms): delay mcp reading the form model by a tick#69265
Open
JeanMeche wants to merge 1 commit into
Open
Conversation
97b1af4 to
9fa0106
Compare
dgp1130
approved these changes
Jun 9, 2026
| untracked(() => { | ||
| initWebMcpForm(formTree, options, injector); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
effect(() => untracked(() => {...})) feels a little weird conceptually, but I guess I don't see a better way of doing it.
We should probably at least have a comment explaining why we don't want to synchronously read the form model.
Member
Author
There was a problem hiding this comment.
That would be an argument for us to have #62075
Reading the form model on init is unsafe as it could depend on inputs (eg a required input). We need to delay the read by a tick (after the inputs are set) to ensure that values can be safely read. fixes angular#69262
9fa0106 to
1f5f28d
Compare
Member
Author
|
Caretaker note: this is good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading the form model on init is unsafe as it could depend on inputs (eg a required input). We need to delay the read by a tick (after the inputs are set) to ensure that values can be safely read.
fixes #69262