feat(core): split tracking for effect and afterRenderEffect#68908
Draft
JeanMeche wants to merge 1 commit into
Draft
feat(core): split tracking for effect and afterRenderEffect#68908JeanMeche wants to merge 1 commit into
effect and afterRenderEffect#68908JeanMeche wants to merge 1 commit into
Conversation
Member
Author
|
Usages:
effect(
splitTracking(
() => trackedValue(),
(val: string, onCleanup: EffectCleanupRegisterFn) => {
onCleanup(() => ... );
},
),
);Single phase afterRenderEffect(
splitTracking(
() => trackedValue(),
(val: string) => {
untrackedValue();
effectCount++;
},
),
);
afterRenderEffect({
earlyRead: () => {
// early read is tracked
trackedValue();
return 42;
},
write: splitTracking(
// tracking fn
() => trackedValue(),
(val: string, earlyReadVal: Signal<number>, onCleanup: EffectCleanupRegisterFn) => {
// non tracking execute fn
untrackedValue();
onCleanup(() => { ... });
},
),
}); |
Member
Author
|
If we had to compare this PR with #68703, we could argue that a helper function is more versitale to achieve the wanted feature. |
Introduce a `splitTracking` helper to separate reactive tracking from non-reactive effect execution by isolating the reactive logic into a dedicated function. fixes angular#56155
|
Deployed adev-preview for 62aeb53 to: https://ng-dev-previews-fw--pr-angular-angular-68908-adev-prev-ew8w3fts.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mere investigation / WIP:
Introduce a
splitTrackinghelper to separate reactive tracking from non-reactive effect execution by isolating the reactive logic into a dedicated function.fixes #56155