Skip to content

refactor(language-server): drop duplicate isAngularCore helpers in se… #68907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erkamyaman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(language-server): drop duplicate isAngularCore helpers in se… #68907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions vscode-ng-language-service/server/src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import {tsDiagnosticToLspDiagnostic} from './diagnostic';
import {ServerHost} from './server_host';
import {
filePathToUri,
isAngularCore,
isConfiguredProject,
isDebugMode,
lspRangeToTsPositions,
Expand Down Expand Up @@ -782,23 +783,6 @@ export class Session {
}
}

function isAngularCore(path: string): boolean {
return isExternalAngularCore(path) || isInternalAngularCore(path);
}

function isExternalAngularCore(path: string): boolean {
return /@angular\/core\/.+\.d\.ts$/.test(path);
}

function isInternalAngularCore(path: string): boolean {
// path in g3
return (
path.endsWith('angular2/rc/packages/core/index.d.ts') ||
// angular/angular repository direct sources
path.includes('angular/packages/core/src')
);
}

function isTypeScriptFile(path: string): boolean {
return path.endsWith('.ts');
}
Expand Down
Loading