refactor(core): implement ɵɵforeignComponent instruction#68787
Draft
leonsenft wants to merge 3 commits into
Draft
refactor(core): implement ɵɵforeignComponent instruction#68787leonsenft wants to merge 3 commits into
leonsenft wants to merge 3 commits into
Conversation
…s in templates We extract the identifier name from the `foreignImports` expression in `ComponentDecoratorHandler` and use a `SelectorlessMatcher` to match element tags against these names. If an element matches both a regular Angular directive and a foreign component, a conflict error is thrown. In addition, we implement strict template semantic validation for these matched foreign components within `TemplateSemanticsChecker`. Elements matched as foreign components only support static attributes and property bindings. Any event bindings, template references, or non-property input bindings (e.g. class, style, or attribute bindings) trigger a semantic error diagnostic. Finally, we skip standard DOM schema checks for foreign components to prevent spurious validation errors since foreign components are not defined in standard HTML schemas.
When a template element matches an imported foreign component, the compiler omits standard element instructions (`ɵɵelementStart`/`ɵɵelement`) and instead generates a single `ɵɵforeignComponent` call. The call passes the exact foreign import wrapper expression defined in `@Component.foreignImports` along with an aggregated object literal containing all static attributes and property bindings. The instruction itself is currently a no-op.
Implement the `ɵɵforeignComponent` instruction to render foreign components (components from other frameworks) inside Angular templates. The instruction creates a host LContainer, instantiates a foreign view, executes the foreign component's RENDER function, inserts the returned native DOM nodes, and registers the disposal hook. Add unit tests to verify element rendering, property passing, and disposal on destruction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #68786
Implement the
ɵɵforeignComponentinstruction to render foreign components (components from other frameworks) inside Angular templates. The instruction creates a host LContainer, instantiates a foreign view, executes the foreign component's RENDER function, inserts the returned native DOM nodes, and registers the disposal hook.Add unit tests to verify element rendering, property passing, and disposal on destruction.