Skip to content

feat(transformers): collect information about di dependencies and pro…#6804

Closed
vsavkin wants to merge 2 commits into
angular:masterfrom
vsavkin:di_transformers_change
Closed

feat(transformers): collect information about di dependencies and pro…#6804
vsavkin wants to merge 2 commits into
angular:masterfrom
vsavkin:di_transformers_change

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Feb 1, 2016

…viders

This PR add support only for useClass. The rest will be implemented by the coming PRs.

@vsavkin vsavkin added comp: dart-transformer action: review The PR is still awaiting reviews from at least one requested reviewer and removed cla: yes labels Feb 1, 2016
tbosch
tbosch reviewed Feb 1, 2016
View reviewed changes
Comment thread modules/angular2/src/compiler/directive_metadata.ts Outdated
Copy link
Copy Markdown
Contributor

@tbosch tbosch Feb 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to CompileMetadataWithIdentifier

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 1, 2016
@vsavkin vsavkin force-pushed the di_transformers_change branch from a6656fa to c0cb11d Compare February 2, 2016 18:02
@vsavkin vsavkin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 2, 2016
@vsavkin vsavkin assigned vsavkin and unassigned tbosch Feb 2, 2016
@vsavkin vsavkin force-pushed the di_transformers_change branch from c0cb11d to 10aa2fd Compare February 2, 2016 18:28
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Feb 2, 2016
@vsavkin vsavkin force-pushed the di_transformers_change branch 3 times, most recently from f7476f1 to b80bc14 Compare February 3, 2016 00:10
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 3, 2016

Merging PR #6804 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6804.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 3, 2016

Merging PR #6804 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6804.

@vsavkin vsavkin force-pushed the di_transformers_change branch 5 times, most recently from 0cfb64c to 616e060 Compare February 5, 2016 00:32
@vsavkin vsavkin force-pushed the di_transformers_change branch from 616e060 to a628246 Compare February 5, 2016 01:15
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Feb 5, 2016

Merging PR #6804 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-6804.

@mhevery mhevery closed this in 22929a1 Feb 5, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vsavkin @mary-poppins @tbosch @alexeagle @IgorMinar @googlebot