Skip to content

#6729 add unit test #6788

Closed
AlexBachmann wants to merge 2 commits into
angular:masterfrom
AlexBachmann:#5502-test-child-router
Closed

#6729 add unit test #6788
AlexBachmann wants to merge 2 commits into
angular:masterfrom
AlexBachmann:#5502-test-child-router

Conversation

@AlexBachmann
Copy link
Copy Markdown

#6729 This unit test verifies that the router emits the right location paths when the parent components has an empty path (/...)

Testcase for Issue #5502

This is the the second unit test for the #6729 pull request, which in turn is a fix for the #5502 issue
@petebacondarwin
Copy link
Copy Markdown
Contributor

@Batch1211 do you know that if you add these commits to your original branch #5502-child-router then it would have simply added them to #6729 and you wouldn't have to open a second PR

@AlexBachmann
Copy link
Copy Markdown
Author

@petebacondarwin You are right. I wanted to write the tests from a clean branch first to see if they fail. Should have merged it in the #5502-child-router branch then, though.

@alexeagle
Copy link
Copy Markdown
Contributor

please add this as a commit on your PR #6729

@alexeagle alexeagle closed this Feb 1, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants