fix(Headers): serializable toJSON#6714
Closed
PatrickJS wants to merge 1 commit into
Closed
Conversation
90f49e2 to
7715386
Compare
45fd831 to
43cb8bb
Compare
Contributor
|
Could you rebase this CL over master please? |
Contributor
|
LGTM, with the caveat that the dart_ddc test passes. |
43cb8bb to
8e252fc
Compare
Contributor
Author
|
@hansl I rebased, I'm not sure why dart_ddc fails |
Contributor
|
Okay Dart DDC just passed. I'm going to stamp this. Good work! |
Contributor
Author
|
kool, thanks |
|
Merging PR #6714 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6714. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6073