Skip to content

chore: track size of a "Hello world" app built with WebPack#6434

Closed
pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:hello_world_size_monitor
Closed

chore: track size of a "Hello world" app built with WebPack#6434
pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:hello_world_size_monitor

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

No description provided.

@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

This is still WIP but opening now to be able to coordinate with @IgorMinar and @yjbanov

@IgorMinar and @yjbanov - I would like to discuss how to organize folders so both JS and Dart versions are "close" to each other but without stepping on each other toes

@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

Remaining tasks:

  • co-exist / unify with Dart
  • run e2e tests before reporting numbers (only report numbers when tests are passing)
  • make sure that we can have multiple tests (hello world, TodoMVC etc.)

@yjbanov
Copy link
Copy Markdown
Contributor

yjbanov commented Jan 13, 2016

We are already measuring the size of "hello world" app under modules/playground. Do we want to switch to a different app?

As for directories, for Dart it would be straight-forward to reuse the modules_dart directory, which is already friends with gulp. What do you think?

@pkozlowski-opensource pkozlowski-opensource force-pushed the hello_world_size_monitor branch 4 times, most recently from 1cd1b31 to 61729ed Compare January 13, 2016 13:31
@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

We are already measuring the size of "hello world" app under modules/playground. Do we want to switch to a different app?

Yes, this is what I got from the discussion with @IgorMinar in https://docs.google.com/document/d/14_PBtkOL0vyyRFmXxkRnz6GFWXjYisxZohDxdl1jV4c/edit#
Indeed setup for a WebPack-based app will be different as compared to a generic playground one.

As for directories, for Dart it would be straight-forward to reuse the modules_dart directory, which is already friends with gulp. What do you think?

Yup, I saw your work on the Dart tracking, but my understanding was that @IgorMinar wants to unify somehow both TS and Dart (as much as it makes sense, of course)

@pkozlowski-opensource pkozlowski-opensource changed the title chore: track size of a "Hello world" app built with WebPack - WIP chore: track size of a "Hello world" app built with WebPack Jan 13, 2016
@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 13, 2016
@yjbanov
Copy link
Copy Markdown
Contributor

yjbanov commented Jan 15, 2016

Sounds good. Looks like you have some vision behind this. I'd like to play an implementor role in this effort, so tell me what I should do :) Otherwise, I can just plug a todo app into what we currently use to measure Dart code size.

Comment thread tools/broccoli/trees/dart_tree.ts Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize the list please

@IgorMinar
Copy link
Copy Markdown
Contributor

The rest looks good

@IgorMinar IgorMinar added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 15, 2016
@pkozlowski-opensource pkozlowski-opensource removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 18, 2016
@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

@IgorMinar I've addressed most of your comments and going tackle the remaining one (removing calls to q.denodify) in a separate PR. Do you want to have another look at this PR or is it good to go?

@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Jan 20, 2016
@mary-poppins
Copy link
Copy Markdown

Merging PR #6434 on behalf of @rkirov to branch presubmit-rkirov-pr-6434.

Comment thread gulpfile.js
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of putting it in our main gulpfile.js, can the webpack code be moved closer to the application itself? This way one doesn't need to look in multiple places to figure out how to package an app for production.

@mhevery mhevery closed this in f7424d5 Jan 21, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants