feat(test_component_builder): allow to override components#6296
Conversation
There was a problem hiding this comment.
Can this be a more descriptive string? 'without jit compiler', maybe?
|
reviewed with @vsavkin in person |
There was a problem hiding this comment.
As a side note, not necessarily for this CL: We need to think of how we'll communicate these options to external users. Setting it up manually like this is almost certainly not what we want them to do.
There was a problem hiding this comment.
A good way to do this would probably be to have two different testing platform constants (see #5975) - e.g. TEST_BROWSER_CODEGENED_APPLICATION_PROVIDERS and TEST_BROWSER_JIT_APPLICATION_PROVIDERS
68921c3 to
2f23331
Compare
|
Merging PR #6296 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-6296. |
|
@tbosch there are non-flake some CI failures on this PR that need to be addressed. They are on the original PR and on the presubmit build I just ran. |
105eaaa to
1eac7bc
Compare
Note: This also works with precompiled templates, i.e. with tests that use transformers. Closes angular#6276
|
This is obsolete as with #6270 we can ensure the same semantics for codegen and interpretative mode. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Note: This also works with precompiled templates, i.e. with tests that use transformers.