PR to review transformer changes from tbosch https://github.com/angular/angular/pull/5993#6171
Closed
kegluneq wants to merge 1 commit into
Closed
PR to review transformer changes from tbosch https://github.com/angular/angular/pull/5993#6171kegluneq wants to merge 1 commit into
kegluneq wants to merge 1 commit into
Conversation
Author
|
Please run |
Author
There was a problem hiding this comment.
nit: Since _extractReferencedType returns Iterable, consider using new Iterable.empty() here rather than a list literal to maintain consistent type
Contributor
|
Changes incorporated into #5993 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @tbosch , will assign to you when I have reviewed