Skip to content

fix(dart/reflection): Fix NoReflectionCapabilities interface #5578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kegluneq wants to merge 1 commit into from
Closed

fix(dart/reflection): Fix NoReflectionCapabilities interface #5578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions modules/angular2/src/core/reflection/reflection.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,45 +7,53 @@ import 'platform_reflection_capabilities.dart';
import 'package:angular2/src/facade/lang.dart';

class NoReflectionCapabilities implements PlatformReflectionCapabilities {
@override
bool isReflectionEnabled() {
return false;
}

@override
Function factory(Type type) {
throw "Cannot find reflection information on ${stringify(type)}";
}

@override
List interfaces(Type type) {
throw "Cannot find reflection information on ${stringify(type)}";
}

List parameters(Type type) {
@override
List parameters(dynamic type) {
throw "Cannot find reflection information on ${stringify(type)}";
}

List annotations(Type type) {
@override
List annotations(dynamic type) {
throw "Cannot find reflection information on ${stringify(type)}";
}

Map propMetadata(Type type) {
@override
Map propMetadata(dynamic type) {
throw "Cannot find reflection information on ${stringify(type)}";
}

@override
GetterFn getter(String name) {
throw "Cannot find getter ${name}";
}

@override
SetterFn setter(String name) {
throw "Cannot find setter ${name}";
}

@override
MethodFn method(String name) {
throw "Cannot find method ${name}";
}

@override
String importUri(Type type) => './';

String moduleId(Type type) => './';
}

final Reflector reflector = new Reflector(new NoReflectionCapabilities());
1 change: 0 additions & 1 deletion modules/angular2/test/public_api_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1449,7 +1449,6 @@ var NG_ALL = [
"NoReflectionCapabilities.interfaces():dart",
"NoReflectionCapabilities.isReflectionEnabled():dart",
"NoReflectionCapabilities.method():dart",
"NoReflectionCapabilities.moduleId():dart",
"NoReflectionCapabilities.parameters():dart",
"NoReflectionCapabilities.propMetadata():dart",
"NoReflectionCapabilities.setter():dart",
Expand Down