Skip to content

refactor(router): don't import public APIs from internal paths#5139

Closed
pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:router_import_public_not_private
Closed

refactor(router): don't import public APIs from internal paths#5139
pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:router_import_public_not_private

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

@pkozlowski-opensource pkozlowski-opensource commented Nov 5, 2015

No description provided.

@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

pkozlowski-opensource commented Nov 5, 2015

This one import change reduces CJS bundle size by 40% (we simply don't have to pull have of the ng2 core). @btford could you please OK this one for me?

@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 5, 2015
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Nov 5, 2015
Closed
@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

pkozlowski-opensource commented Nov 5, 2015

Got LGTM from Brian, merging.

@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Nov 5, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 5, 2015

Merging PR #5139 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-5139.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Nov 5, 2015
@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 6, 2015

Merging PR #5139 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-5139.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 6, 2015

Merging PR #5139 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-5139.

@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 6, 2015

Merging PR #5139 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-5139.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pkozlowski-opensource @mary-poppins @btford @googlebot