Skip to content

Support dev mode when running in Javascript.#5106

Closed
alxhub wants to merge 3 commits into
angular:masterfrom
alxhub:dev-mode
Closed

Support dev mode when running in Javascript.#5106
alxhub wants to merge 3 commits into
angular:masterfrom
alxhub:dev-mode

Conversation

@alxhub
Copy link
Copy Markdown
Member

@alxhub alxhub commented Nov 3, 2015

No description provided.

@alxhub alxhub self-assigned this Nov 3, 2015
@alxhub alxhub added this to the beta-00 milestone Nov 3, 2015
@alxhub alxhub force-pushed the dev-mode branch 6 times, most recently from ab7111f to 42faacf Compare November 4, 2015 22:11
@alxhub alxhub assigned IgorMinar and unassigned alxhub Nov 4, 2015
@alxhub alxhub added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Nov 4, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor

IgorMinar commented Nov 5, 2015

I don't see an addition in the public api spec. shouldn't the public api spec fail or did you not reexport the symbol correctly?

IgorMinar
IgorMinar reviewed Nov 5, 2015
View reviewed changes
Comment thread test-main.js Outdated
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar Nov 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use public api here just as anyone else would. so import it from angular2/core instead.

(the browser_adapter is imported from private entrypoint and there is a pending bug for that)

Copy link
Copy Markdown
Member Author

@alxhub alxhub Nov 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@IgorMinar
Copy link
Copy Markdown
Contributor

IgorMinar commented Nov 5, 2015

let's try to make this work semantically in the same way as it works in Dart.

IgorMinar
IgorMinar reviewed Nov 5, 2015
View reviewed changes
Comment thread modules/angular2/src/core/facade/lang.ts Outdated
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar Nov 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doc should be of public-api quality. can you please improve?

@alxhub
Copy link
Copy Markdown
Member Author

alxhub commented Nov 5, 2015

I don't know why the public api spec test wasn't picking up on the new symbol. I renamed it and then it needed to be added.

@alxhub alxhub force-pushed the dev-mode branch 5 times, most recently from 9efe932 to ac71996 Compare November 6, 2015 00:22
@alxhub alxhub force-pushed the dev-mode branch 4 times, most recently from 7a0d64b to 7609b74 Compare November 6, 2015 01:26
IgorMinar
IgorMinar reviewed Nov 6, 2015
View reviewed changes
Comment thread tools/broccoli/html-replace/SCRIPTS.html Outdated
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar Nov 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove plz

@IgorMinar
Copy link
Copy Markdown
Contributor

IgorMinar commented Nov 6, 2015

otherwise lgtm

@IgorMinar IgorMinar added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 6, 2015
@IgorMinar IgorMinar assigned alxhub and unassigned IgorMinar Nov 6, 2015
@alxhub
Copy link
Copy Markdown
Member Author

alxhub commented Nov 6, 2015

Okay, I implemented all the changes. I'll push this as soon as Travis completes.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 6, 2015

Merging PR #5106 on behalf of @alxhub to branch presubmit-alxhub-pr-5106.

@alxhub alxhub added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Nov 6, 2015
@alxhub alxhub closed this in aa70275 Nov 6, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alxhub alxhub

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Milestone

beta.0

Development

Successfully merging this pull request may close these issues.

4 participants

@alxhub @IgorMinar @mary-poppins @googlebot